sphinx.ext.coverage: Remove errant print #11593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect this was left over when the coverage report was introduced recently. This is noisy and we already have the capability to log missing modules to stdout as-is. Signed-off-by: Stephen Finucane <[email protected]>
Contributor
Author
|
This is also done in #11592 but I'm aware that might take longer to review/discuss so I'd like to get this in before we release the coverage report feature. |
picnixz
approved these changes
Aug 15, 2023
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
Good catch! Are there other errant prints in the project? (perhaps in tests or something like that). If so, we could remove the as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Bugfix
Purpose
Remove an errant print. I suspect this was left over when the coverage report was introduced recently. This is noisy and we already have the capability to log missing modules to stdout as-is.
Detail
(none)
Relates
(none)